On 20/05/16 10:51, Daeseok Youn wrote:
> the "brd" was already checked for NULL before calling dgnc_do_remap().
>
> Signed-off-by: Daeseok Youn <daeseok.youn@xxxxxxxxx>
> ---
> drivers/staging/dgnc/dgnc_driver.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/staging/dgnc/dgnc_driver.c b/drivers/staging/dgnc/dgnc_driver.c
> index 22257d2..1882ef5 100644
> --- a/drivers/staging/dgnc/dgnc_driver.c
> +++ b/drivers/staging/dgnc/dgnc_driver.c
> @@ -599,9 +599,6 @@ static int dgnc_finalize_board_init(struct dgnc_board *brd)
> */
> static void dgnc_do_remap(struct dgnc_board *brd)
> {
> - if (!brd || brd->magic != DGNC_BOARD_MAGIC)
> - return;
> -
> brd->re_map_membase = ioremap(brd->membase, 0x1000);
> }
>
>
Same comment as the 1/2 patch.
Do you want to keep the brd->magic != DGNC_BOARD_MAGIC check?
Thanks,
Luis
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
