Thanks, Dan. Acked-by: Sudarsana Reddy Kalluru <sudarsana.kalluru@xxxxxxxxxx> -----Original Message----- From: Dan Carpenter [mailto:dan.carpenter@xxxxxxxxxx] Sent: 23 May 2016 15:50 To: Yuval Mintz <Yuval.Mintz@xxxxxxxxxx>; Sudarsana Kalluru <Sudarsana.Kalluru@xxxxxxxxxx> Cc: Ariel Elior <Ariel.Elior@xxxxxxxxxx>; Dept-Eng Everest Linux L2 <everest-linux-l2@xxxxxxxxxx>; netdev <netdev@xxxxxxxxxxxxxxx>; kernel-janitors@xxxxxxxxxxxxxxx Subject: [patch] qed: signedness bug in qed_dcbx_process_tlv() "priority" needs to be signed for the error handling to work. Fixes: 39651abd2814 ('qed: add support for dcbx.') Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> --- Applies to the main net tree. diff --git a/drivers/net/ethernet/qlogic/qed/qed_dcbx.c b/drivers/net/ethernet/qlogic/qed/qed_dcbx.c index cbf58e1..a06d19a 100644 --- a/drivers/net/ethernet/qlogic/qed/qed_dcbx.c +++ b/drivers/net/ethernet/qlogic/qed/qed_dcbx.c @@ -192,9 +192,10 @@ qed_dcbx_process_tlv(struct qed_hwfn *p_hwfn, struct dcbx_app_priority_entry *p_tbl, u32 pri_tc_tbl, int count, bool dcbx_enabled) { - u8 tc, priority, priority_map; + u8 tc, priority_map; enum dcbx_protocol_type type; u16 protocol_id; + int priority; bool enable; int i; -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html