> -----Original Message----- > From: Dan Carpenter [mailto:dan.carpenter@xxxxxxxxxx] > Sent: Tuesday, May 17, 2016 10:32 AM > To: Jonathan Cameron <jic23@xxxxxxxxxx>; Breana, Tiberiu A > <tiberiu.a.breana@xxxxxxxxx> > Cc: Hartmut Knaack <knaack.h@xxxxxx>; Lars-Peter Clausen > <lars@xxxxxxxxxx>; Peter Meerwald-Stadler <pmeerw@xxxxxxxxxx>; > linux-iio@xxxxxxxxxxxxxxx; kernel-janitors@xxxxxxxxxxxxxxx > Subject: [patch] iio: humidity: Remove a stray unlock > > We haven't taken the lock yet so we don't need to unlock here. > > Fixes: 0d96d5ead3f7 ('iio: humidity: Add triggered buffer support for > AM2315') > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > > diff --git a/drivers/iio/humidity/am2315.c b/drivers/iio/humidity/am2315.c > index 3be6d20..1153591 100644 > --- a/drivers/iio/humidity/am2315.c > +++ b/drivers/iio/humidity/am2315.c > @@ -165,10 +165,8 @@ static irqreturn_t am2315_trigger_handler(int irq, > void *p) > struct am2315_sensor_data sensor_data; > > ret = am2315_read_data(data, &sensor_data); > - if (ret < 0) { > - mutex_unlock(&data->lock); > + if (ret < 0) > goto err; > - } > > mutex_lock(&data->lock); > if (*(indio_dev->active_scan_mask) == > AM2315_ALL_CHANNEL_MASK) { That one must have slipped by during development versions. You might also want to add am2315 in the patch title. Thanks, Acked-by: Tiberiu Breana <tiberiu.a.breana@xxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
