On Mon, 16 May 2016, SF Markus Elfring wrote: > From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> > Date: Sun, 15 May 2016 19:20:28 +0200 > > The platform_device_put() function was called in one case by the > add_numbered_child() function during error handling even if the passed > variable "pdev" contained a null pointer. > > * Change an error message. Why? Is dev_err needed? Doesn't it already print out the device name? In any case, the only source of failure is failure of a kzalloc in platform_device_alloc, which means that a complete backtrace would be generated, so it is not clear that any message is needed at all. julia > > * Return directly in this case. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> > --- > drivers/mfd/twl-core.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/drivers/mfd/twl-core.c b/drivers/mfd/twl-core.c > index 831696e..dc34e69 100644 > --- a/drivers/mfd/twl-core.c > +++ b/drivers/mfd/twl-core.c > @@ -623,9 +623,10 @@ add_numbered_child(unsigned mod_no, const char *name, int num, > > pdev = platform_device_alloc(name, num); > if (!pdev) { > - dev_dbg(&twl->client->dev, "can't alloc dev\n"); > - status = -ENOMEM; > - goto err; > + dev_err(&twl->client->dev, > + "Allocation failed for device: %s\n", > + name); > + return ERR_PTR(-ENOMEM); > } > > pdev->dev.parent = &twl->client->dev; > -- > 2.8.2 > > -- > To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html