Apologies for the delay. Patch looks good. Acked by: Anil Gurumurthy <anil.gurumurthy@xxxxxxxxxx> -----Original Message----- From: Martin K. Petersen [mailto:martin.petersen@xxxxxxxxxx] Sent: 06 May 2016 06:54 To: Dan Carpenter <dan.carpenter@xxxxxxxxxx> Cc: Anil Gurumurthy <Anil.Gurumurthy@xxxxxxxxxx>; Sudarsana Kalluru <Sudarsana.Kalluru@xxxxxxxxxx>; James E.J. Bottomley <jejb@xxxxxxxxxxxxxxxxxx>; Martin K. Petersen <martin.petersen@xxxxxxxxxx>; linux-scsi <linux-scsi@xxxxxxxxxxxxxxx>; kernel-janitors@xxxxxxxxxxxxxxx Subject: Re: [PATCH resend v2] [SCSI] bfa: fix bfa_fcb_itnim_alloc() error handling >>>>> "Dan" == Dan Carpenter <dan.carpenter@xxxxxxxxxx> writes: Dan> The caller assumes that "itnim" is NULL on error and non-NULL on Dan> success but really "itnim" is uninitialized on error. This Dan> function should just use normal error handling where it returns Dan> zero on success and negative on failure. Anil, please review: https://patchwork.kernel.org/patch/8820751/ -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
