Re: [PATCH] efivarfs: merge boolean flag arguments

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 21 Apr, at 03:24:29PM, Julia Lawall wrote:
> The parameters atomic and duplicates of efivar_init always have opposite
> values.  Drop the parameter atomic, replace the uses of !atomic with
> duplicates, and update the call sites accordingly.
> 
> The code using duplicates is slightly reorganized with an else, to avoid
> duplicating the lock code.
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@xxxxxxx>
> 
> ---
> Not tested.  I have assumed that the calls to both variable_is_present and
> dup_variable_bug need to be out of the lock.
> 
>  drivers/firmware/efi/efivars.c |    5 ++---
>  drivers/firmware/efi/vars.c    |   23 ++++++++++-------------
>  fs/efivarfs/super.c            |    3 +--
>  include/linux/efi.h            |    3 +--
>  4 files changed, 14 insertions(+), 20 deletions(-)

Applied. Thanks Julia.
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux