On Fri, Mar 25, 2016 at 05:51:20PM +0900, Inki Dae wrote: > Hi Dan, > > 2016년 03월 17일 19:39에 Dan Carpenter 이(가) 쓴 글: > > We know "ret" is zero and the test makes static checkers complain so > > let's delete this printk. > > > > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > > > > diff --git a/drivers/gpu/drm/exynos/exynos_drm_mic.c b/drivers/gpu/drm/exynos/exynos_drm_mic.c > > index 890c9b1..12db353 100644 > > --- a/drivers/gpu/drm/exynos/exynos_drm_mic.c > > +++ b/drivers/gpu/drm/exynos/exynos_drm_mic.c > > @@ -130,8 +130,6 @@ static void mic_set_path(struct exynos_mic *mic, bool enable) > > val &= ~(MIC0_RGB_MUX | MIC0_I80_MUX | MIC0_ON_MUX); > > > > regmap_write(mic->sysreg, DSD_CFG_MUX, val); > > - if (ret) > > - DRM_ERROR("mic: Failed to read system register\n"); > > I think we missed to keep return value from regmap_write function, > ret = regmap_write(mic->sysreg, ....); > if (ret) > ... Yeah. You're right. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html