On Tue, Mar 08, 2016 at 03:05:46PM +0300, Dan Carpenter wrote: > This should be an IS_ERR() check. mount_pseudo() returns error pointers > and this function should return the error pointer to its caller as well. > > Fixes: 3684aa7099e0 ('block-dev: enable writeback cgroup support') > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> Looks fine. Would be much nicer to simply pass possible flags as an argument to mount_pseudo to avoid this whole dance.. Reviewed-by: Christoph Hellwig <hch@xxxxxx> -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html