On 03/14/16 at 01:58pm, Dan Carpenter wrote: > On Fri, Mar 11, 2016 at 11:38:19PM +0800, Minfei Huang wrote: > > I think we can modify the logic a bit to make code simple. Thus gcc will > > not complain about any more, and the logic is earier. > > This is a Smatch warning, not a GCC warning. If you think the new code > is clearer, that's fine but don't just silence the warning to please > Smatch. I'm pretty sure I can silence this warning in Smatch. > > regards, > dan carpenter > Hi, Dan. If not a GCC warning, I'm fine to fix it in Smatch, since the code logic is clear enough. Thanks Minfei -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html