Re: tracing: Make tracer_flags use the right set_flag callback

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 11 Mar 2016 06:50:07 -0500 (EST)
Chunyu Hu <chuhu@xxxxxxxxxx> wrote:


> Thanks so much for catching this. I missed this check. I was just
> thinking that this fail was nearly impossible, and during my tests
> I didn't hit any warn, so i missed this. You taught me a lesson. 
> BTW, How did you hit the warn? a special gcc version / feature?
> 
> You are right, It should be a 'goto out', this has already tested by me.
>  
>                           if (!type->flags) {
>                                   ret = -ENOMEM;
>                                   goto out;
>                           }
> 
> Hi Steve,
> I'm so sorry for this. Can I resubmit a v2 for my part of the patch?
> 

What I push to linux-next doesn't get rebased. Please just send a patch
to fix this on top of what's already in my for-next branch.

Thanks!


-- Steve
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux