On Friday 20 November 2015 11:56:39 SF Markus Elfring wrote: > > On top of that, by going through the batman-adv code you might agree > > that the current style is actually not a bad idea. > > I got the impression that the current Linux coding style convention > disagrees around the affected jump label selection to some degree, > doesn't it? Yes, see "Chapter 7: Centralized exiting of functions". But your patch doesn't seem to apply anymore. Can you please resent it or mark it correctly in patchwork [1]. There was also another suggestion in the past: * https://patchwork.open-mesh.org/patch/4081/ [2] I have prepared a overview of functions and their goto's [3] to make it easier to spot interesting places. Kind regards, Sven [1] https://patchwork.open-mesh.org/patch/4724/ You can find an updated version at https://git.open-mesh.org/batman-adv.git/patch/1b79cb12821da928b4cf2d116469dfdcbe66d8cd [2] Update version: https://git.open-mesh.org/batman-adv.git/commit/28578c9dd0e592f1c69c44ab7723021b1e8c5b28 [3] https://git.open-mesh.org/batman-adv.git/blob/783c827d01b3644ac09a0f32fe4a9dfa8d6debd3:/TODO
Attachment:
signature.asc
Description: This is a digitally signed message part.