On Tue, 2016-02-02 at 13:00 +0300, Dan Carpenter wrote: > The NULL test here is reversed. [] > diff --git a/drivers/net/wireless/marvell/mwifiex/scan.c b/drivers/net/wireless/marvell/mwifiex/scan.c [] > @@ -2196,7 +2196,7 @@ int mwifiex_ret_802_11_scan(struct mwifiex_private *priv, > > pmatch = adapter->nd_info->matches[idx]; > > - if (!pmatch) { > + if (pmatch) { > memset(pmatch, 0, sizeof(*pmatch)); As it's just been kzalloc'ed, this memset seems unnecessary as well. -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html