It's not the return where we should trigger the warning it's at the rcu_assign_pointer(sta->ampdu_mlme.tid_rx[tid], tid_agg_rx); line. That's for correctness, but also it should be slightly easier. Or it should cut down on false positives if we ignored returns and only looked global scope type assignements. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html