>> * Return directly if a memory allocation failed at the beginning. >> >> * Adjust jump targets according to the Linux coding style convention. >> >> This issue was detected by using the Coccinelle software. > > Is this really better? > > Perhaps this particular static analysis isn't too useful. The opinions are still evolving for such a kind of search pattern. > Why not just allocate once and assign a second pointer? > > local_rqfpr = kmalloc_array(2 * (MAX_FILER_IDX + 1), > sizeof(unsigned int), GFP_KERNEL); > if (!local_rqfpr) > goto err; > > local_rqfcr = &local_rqfpr[MAX_FILER_IDX + 1]; Do you suggest to use only one array (instead of two as before) here? Regards, Markus -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
