On Wed, Jan 13, 2016 at 03:21:17PM +0300, Dan Carpenter wrote: > If we return 1 here, then the caller treats it as an error and returns > -EINVAL. It causes a static checker warning to treat positive returns > as an error. > > Fixes: 1aba86d67f34 ('Btrfs: fix easily get into ENOSPC in mixed case') > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > --- > I would appreciate a little review here. This patch doesn't change > behavior, but it's possible that we had intended to do something else. No, it makes sense to switch it to -EINVAL. Thanks. Reviewed-by: David Sterba <dsterba@xxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html