Re: [patch] RDMA/nes: checking for NULL instead of IS_ERR

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jan 12, 2016 at 12:27:43PM +0300, Dan Carpenter wrote:
> nes_reg_phys_mr() returns ERR_PTRs on error.  It doesn't return NULL.
> 
> This bug has been there for a while, but we recently changed from
> calling a function pointer to calling nes_reg_phys_mr() directly so now
> Smatch is able to detect the bug.

Looks fine,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux