On Thu, 2016-01-07 at 20:30 +0100, SF Markus Elfring wrote: > > > Adjust a jump target to eliminate a check before error logging. > > > Use the identifier "report_failure" instead of "err". > > I don't see much value in those changes > Thanks for your feedback. > > Using the 'err' label is ok as it is not misleading and common use. > Is such a short jump label enough explanation for the information > "what" and "why"? When there is only one type of error possible, yes. > > And, there is no need to optimize the check since this is not the > > fast path > Really? - Is it a bit more efficient to avoid a double check for the > variable "ret" at the end of the current implementation for the > discussed function? Before asking questions you could answer yourself, please look at object code produced by the compiler before and after your proposed changes. -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
