On Thu, Jan 07, 2016 at 12:36:48PM +0300, Dan Carpenter wrote: > It feels like we should set the tasklet data before enabling it. > > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> Applied, thank you. > > diff --git a/drivers/input/keyboard/omap-keypad.c b/drivers/input/keyboard/omap-keypad.c > index 7502e46..75ad666 100644 > --- a/drivers/input/keyboard/omap-keypad.c > +++ b/drivers/input/keyboard/omap-keypad.c > @@ -292,8 +292,8 @@ static int omap_kp_probe(struct platform_device *pdev) > setup_timer(&omap_kp->timer, omap_kp_timer, (unsigned long)omap_kp); > > /* get the irq and init timer*/ > - tasklet_enable(&kp_tasklet); > kp_tasklet.data = (unsigned long) omap_kp; > + tasklet_enable(&kp_tasklet); > > ret = device_create_file(&pdev->dev, &dev_attr_enable); > if (ret < 0) -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
