On Tue, 5 Jan 2016, Felipe Ferreri Tonello wrote: > Hi Dan, > > On 05/01/16 12:44, Dan Carpenter wrote: > > On Tue, Jan 05, 2016 at 01:28:11PM +0100, Julia Lawall wrote: > >> > >> > >> On Tue, 5 Jan 2016, kbuild test robot wrote: > >> > >>> Hi Dan, > >>> > >>> [auto build test WARNING on balbi-usb/next] > >>> [also build test WARNING on v4.4-rc8 next-20160105] > >>> [if your patch is applied to the wrong git tree, please drop us a note to help improving the system] > >>> > >>> url: https://github.com/0day-ci/linux/commits/Dan-Carpenter/usb-gadget-f_midi-missing-unlock-on-error-path/20160105-183115 > >>> base: https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git next > >>> > >>> > >>> coccinelle warnings: (new ones prefixed by >>) > >>> > >>>>> drivers/usb/gadget/function/f_midi.c:1233:14-21: ERROR: midi is NULL but dereferenced. > >> > >> It's a false positive for coccinelle, but I wonder if avoiding duplicating > >> the mutex_lock is really worth it? > > > > It's not the most beautiful code in the world. I considered a bunch of > > different ways to write it... This is what Felipe Tonello wanted, > > though. > > This case is not a matter of been pretty but a matter of been less error > prone. > > What would you suggest? I thought to be a little less subtle about midi, it would be easier to keep the first few mutex_unlocks up where they were. But up to you. julia -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
