On Sun, 20 Dec 2015, Joe Perches wrote: > On Sat, 2015-12-19 at 13:59 +0300, Dan Carpenter wrote: > > There is a type bug so it always returns success. > > How many false positives do you have to sift > through to find this sort of error? The return type is thoughtfully bool, so it should be easy in this case. The function has a return -EINVAL and a return true, so even without the return type it would be locally apparent that there is an inconsistency. julia > > > +++ b/drivers/net/wireless/ath/ath9k/eeprom.c > > @@ -206,7 +206,7 @@ bool ath9k_hw_nvram_check_version(struct ath_hw *ah, int version, int minrev) > > ath_err(common, "Bad EEPROM VER 0x%04x or REV 0x%04x\n", > > ah->eep_ops->get_eeprom_ver(ah), > > ah->eep_ops->get_eeprom_rev(ah)); > > - return -EINVAL; > > + return false; > > } > > > > return true; > > -- > To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html >
