Re: [PATCH] USB-FHCI: Use a signed return type for fhci_create_ep()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Dec 19, 2015 at 09:55:02PM +0100, SF Markus Elfring wrote:
> > Just make it an int.
> 
> Thanks for your suggestion.
> 
> Will any more software developers prefer this data type
> at some source code places?
> 

Use s32 if the hardware spec specifies that you must.  Otherwise prefer
ordinary types.

> 
> > The caller also casts it to u32...
> 
> Do you want to get rid of similar casts in affected functions?

If you want, that would be great.  I just enjoy complaining generally,
though.  :P

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux