Re: [patch] rt2x00: type bug in _rt2500usb_register_read()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Nov 26, 2015 at 01:21:48PM +0100, walter harms wrote:
> > If the low 16 bits were initialized to zero then this code would only be
> > a problem on big endian systems.

> perhaps, cleaning *value would be sufficient ? Avoiding the need for a tmp var.
> 
> *value = 0
> rt2500usb_register_read(rt2x00dev, offset, (u16 *)value);
> 

Because if you initialize value then you still have a bug on big endian
systems.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux