Am 25.11.2015 um 17:39 schrieb Greg Kroah-Hartman: > On Thu, Nov 05, 2015 at 01:20:33PM +0100, SF Markus Elfring wrote: >> From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> >> Date: Thu, 5 Nov 2015 12:48:58 +0100 >> >> The functions "kfree" and "kobject_put" were called in a few cases by the >> function "class_register_type" during error handling even if the passed >> variable contained a null pointer. >> >> This implementation detail could be improved by the adjustment of >> jump targets. >> >> Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> >> --- >> drivers/staging/lustre/lustre/obdclass/genops.c | 26 +++++++++++++++---------- >> 1 file changed, 16 insertions(+), 10 deletions(-) > > Does not apply to my staging-next branch :( I get also a result like the following together with the software "Linux next-20151126". ;-) elfring@Sonne:~/Projekte/Linux/next-patched> LANG=C git apply ~/Projekte/Bau/Linux/scripts/Coccinelle/deletions1/next/20151102/Flicken/0003-staging-lustre-Less-function-calls-in-class_register.patch error: patch failed: drivers/staging/lustre/lustre/obdclass/genops.c:214 error: drivers/staging/lustre/lustre/obdclass/genops.c: patch does not apply Do you try this update suggestion out without integrating the corresponding previous update suggestion "Delete unnecessary checks before two function calls" where I proposed to remove extra checks before a few calls of the function "kobject_put" (which seems to matter for the patch hunk in the shown error message)? https://lkml.org/lkml/2015/11/5/276 https://www.mail-archive.com/linux-kernel@xxxxxxxxxxxxxxx/msg1013635.html Would you like to reject the first update step from this patch series so that I need to adapt my approach to your software design decision? Regards, Markus -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
