SF Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> writes:
> The dma_pool_destroy() function tests whether its argument is NULL
> and then returns immediately. Thus the test around the call is not needed.
>
> This issue was detected by using the Coccinelle software.
> --- a/drivers/net/ethernet/xscale/ixp4xx_eth.c
> +++ b/drivers/net/ethernet/xscale/ixp4xx_eth.c
> @@ -1192,7 +1192,7 @@ static void destroy_queues(struct port *port)
> port->desc_tab = NULL;
> }
>
> - if (!ports_open && dma_pool) {
> + if (!ports_open) {
> dma_pool_destroy(dma_pool);
> dma_pool = NULL;
> }
Acked-by: Krzysztof Halasa <khalasa@xxxxxxx>
--
Krzysztof Halasa
Industrial Research Institute for Automation and Measurements PIAP
Al. Jerozolimskie 202, 02-486 Warsaw, Poland
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
