Re: [patch] nfsd: fix a warning message

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, 21 Nov 2015 13:28:50 +0300
Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:

> The WARN() macro takes a condition and a format string.  The condition
> was accidentally left out here so it just prints the function name
> instead of the message.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> 
> diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
> index 6b800b5..7af023f 100644
> --- a/fs/nfsd/nfs4state.c
> +++ b/fs/nfsd/nfs4state.c
> @@ -2240,7 +2240,8 @@ nfsd4_store_cache_entry(struct nfsd4_compoundres *resp)
>  	base = resp->cstate.data_offset;
>  	slot->sl_datalen = buf->len - base;
>  	if (read_bytes_from_xdr_buf(buf, base, slot->sl_data, slot->sl_datalen))
> -		WARN("%s: sessions DRC could not cache compound\n", __func__);
> +		WARN(1, "%s: sessions DRC could not cache compound\n",
> +		     __func__);
>  	return;
>  }
>  

Reviewed-by: Jeff Layton <jlayton@xxxxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux