From: Julia Lawall <julia.lawall@xxxxxxx> Date: Thu, 5 Nov 2015 21:08:17 +0100 (CET) > On Thu, 5 Nov 2015, David Miller wrote: > >> From: Julia Lawall <Julia.Lawall@xxxxxxx> >> Date: Thu, 5 Nov 2015 11:18:16 +0100 >> >> > Move the variable declarations from the for_nexthops macro to the >> > surrounding context, so that it is clear where these variables are >> > declared. This also makes it possible to remove the endfor_nexthops macro. >> > >> > This change adds new arguments to the macro for_nexthops. They are ordered >> > such that a pointer to the referenced object comes first, the index in the >> > list comes next, and the list itself comes last, roughly in analogy with >> > the list_for_each macros. >> > >> > Signed-off-by: Julia Lawall <Julia.Lawall@xxxxxxx> >> > >> > --- >> > >> > This patch takes care of a single file, where the macros are defined >> > locally. If the basic transformation looks OK, I will change the other >> > files that either likewise define their own macros or use the macros in >> > net/mpls/internal.h. The potentially affected files are: >> ... >> >> This looks fine to me. > > Would it be preferable to remove the macro entirely and inline the for > loop header? Could you show me an example of how this would look exactly? -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
