> We accidentally return success instead of -ENOMEM here. > > Fixes: fe56b9e6a8d9 ('qed: Add module with basic common support') > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > Thanks. Although you might also argue that it's good enough for this function to always return -ENOMEM [given it's a resource allocation functions] instead of bothering with setting 'rc' with correct error codes. Regardless, Acked-by: Yuval Mintz <Yuval.Mintz@xxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html