Re: [patch] ACPI/CPPC: signedness bug in register_pcc_channel()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 22 October 2015 at 15:52, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
> The "pcc_subspace_idx" is -1 if it hasn't been initialized yet.  We need
> it to be signed.
>
> Fixes: 337aadff8e45 ('ACPI: Introduce CPU performance controls using CPPC')
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
>
> diff --git a/drivers/acpi/cppc_acpi.c b/drivers/acpi/cppc_acpi.c
> index 0bbf84b..2ed5516 100644
> --- a/drivers/acpi/cppc_acpi.c
> +++ b/drivers/acpi/cppc_acpi.c
> @@ -302,7 +302,7 @@ err_ret:
>  }
>  EXPORT_SYMBOL_GPL(acpi_get_psd_map);
>
> -static int register_pcc_channel(unsigned pcc_subspace_idx)
> +static int register_pcc_channel(int pcc_subspace_idx)
>  {
>         struct acpi_pcct_subspace *cppc_ss;
>         unsigned int len;

Acked-by: Ashwin Chaugule <ashwin.chaugule@xxxxxxxxxx>

Thanks,
Ashwin.
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux