Yeah, there is an integer overflow before we check but so far as I can see it is harmless. The kernel is full of harmless integer overflows. I sort of feel like this is the simplest way to write it and the other ways feel over engineered and unweildy. Care to propose a patch, though? regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html