On 21/10/15 21:41, Julia Lawall wrote:
for_each_available_child_of_node performs an of_node_get on each iteration, so a break out of the loop requires an of_node_put. The semantic patch that fixes this problem is as follows (http://coccinelle.lip6.fr): // <smpl> @@ expression root,e; local idexpression child; @@ for_each_available_child_of_node(root, child) { ... when != of_node_put(child) when != e = child ( return child; | + of_node_put(child); ? return ...; ) ... } // </smpl> Signed-off-by: Julia Lawall <Julia.Lawall@xxxxxxx>
Thanks for the fix. Acked-by: Sudeep Holla <sudeep.holla@xxxxxxx> PS: Since this driver is queued via arm-soc, it needs to go via them or wait for v4.4-rc1 and then queue via clk tree. -- Regards, Sudeep -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
