Re: [patch] ALSA: oss: underflow in snd_mixer_oss_proc_write()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 15 Oct 2015 09:01:42 +0200,
Dan Carpenter wrote:
> 
> We cap the upper bound of "idx" but not the negative side.  Let's make
> it unsigned to fix this.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

Applied, thanks.


Takashi

> 
> diff --git a/sound/core/oss/mixer_oss.c b/sound/core/oss/mixer_oss.c
> index a99f720..7a8c79d 100644
> --- a/sound/core/oss/mixer_oss.c
> +++ b/sound/core/oss/mixer_oss.c
> @@ -1177,7 +1177,8 @@ static void snd_mixer_oss_proc_write(struct snd_info_entry *entry,
>  	struct snd_mixer_oss *mixer = entry->private_data;
>  	char line[128], str[32], idxstr[16];
>  	const char *cptr;
> -	int ch, idx;
> +	unsigned int idx;
> +	int ch;
>  	struct snd_mixer_oss_assign_table *tbl;
>  	struct slot *slot;
>  
> 
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux