On Tue, 13 Oct 2015 09:07:56 +0200, Dan Carpenter wrote: > > "params->tstamp_mode" is a user supplied int. We cap the maximum but > allow negative values by mistake. It's harmless but static checkers > complain. > > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> You already sent the same fix and it was applied in the commit 145d92e77e6f. thanks, Takashi > > diff --git a/sound/core/pcm_native.c b/sound/core/pcm_native.c > index 75888dd..4863af5 100644 > --- a/sound/core/pcm_native.c > +++ b/sound/core/pcm_native.c > @@ -650,7 +650,8 @@ static int snd_pcm_sw_params(struct snd_pcm_substream *substream, > } > snd_pcm_stream_unlock_irq(substream); > > - if (params->tstamp_mode > SNDRV_PCM_TSTAMP_LAST) > + if (params->tstamp_mode < 0 || > + params->tstamp_mode > SNDRV_PCM_TSTAMP_LAST) > return -EINVAL; > if (params->proto >= SNDRV_PROTOCOL_VERSION(2, 0, 12) && > params->tstamp_type > SNDRV_PCM_TSTAMP_TYPE_LAST) > -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
