On Wed, Sep 16, 2015 at 09:19:49AM +0300, Dan Carpenter wrote: > The goto is correct and the unreachable "return -EINVAL" should be > removed. > > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> Of course Acked-by: Ludovic Desroches <ludovic.desroches@xxxxxxxxx> Thanks > > diff --git a/drivers/mmc/host/sdhci-of-at91.c b/drivers/mmc/host/sdhci-of-at91.c > index d155664..d3df786 100644 > --- a/drivers/mmc/host/sdhci-of-at91.c > +++ b/drivers/mmc/host/sdhci-of-at91.c > @@ -110,7 +110,6 @@ static int sdhci_at91_probe(struct platform_device *pdev) > if (ret < 0) { > dev_err(&pdev->dev, "failed to set gck"); > goto hclock_disable_unprepare; > - return -EINVAL; > } > /* > * We need to check if we have the requested rate for gck because in -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html