On 24/08/15 22:54, Dan Carpenter wrote: > The limit should be "PAGE_SIZE - len" instead of PAGE_SIZE. Also let's > use scnprintf() because snprintf() returns the number of bytes which > would have been printed if there were space and scnprintf() returns the > number of bytes actually printed. > > I don't think we are ever going to actually hit this limit in real life. > > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > > diff --git a/drivers/video/fbdev/core/fbsysfs.c b/drivers/video/fbdev/core/fbsysfs.c > index 60c3f0a..15755ce 100644 > --- a/drivers/video/fbdev/core/fbsysfs.c > +++ b/drivers/video/fbdev/core/fbsysfs.c > @@ -485,7 +485,7 @@ static ssize_t show_bl_curve(struct device *device, > > mutex_lock(&fb_info->bl_curve_mutex); > for (i = 0; i < FB_BACKLIGHT_LEVELS; i += 8) > - len += snprintf(&buf[len], PAGE_SIZE, "%8ph\n", > + len += scnprintf(&buf[len], PAGE_SIZE - len, "%8ph\n", > fb_info->bl_curve + i); > mutex_unlock(&fb_info->bl_curve_mutex); Thanks, queued for 4.3. Tomi
Attachment:
signature.asc
Description: OpenPGP digital signature
