On Fri, Aug 28, 2015 at 9:02 PM, Doug Ledford <dledford@xxxxxxxxxx> wrote: > On 08/28/2015 09:10 PM, ira.weiny wrote: >> On Tue, Aug 18, 2015 at 12:22:10PM +0300, Dan Carpenter wrote: >>> Smatch says that, based on the indenting, we should probably add curly >>> braces here. >>> >>> Fixes: 230145ff8124 ('IB/core: Add RoCE GID table management') >>> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> >>> >> >> Reviewed-by: Ira Weiny <ira.weiny@xxxxxxxxx> > > I've picked this patch up (earlier today), so I missed your reviewed-by: > tag. Added. wait, Doug, when the offending patch goes upstream, their commit ID will not be the one denoted here, right? I would suggest that you either hold off with this fix till the other patch goes upstream in 4,3-rc1 and you have a proper ID or squash it there now. BTW - the way net-next is organized/managed, pre-linus-tree commit ID remain the same also after they land there, so in that respect and other linux-rdma maintenance related aspects we discussed during LPC - it would be good if you can talk to Dave and see how he gets things going for net-next Or -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html