On 23 August 2015 at 02:11, Julia Lawall <Julia.Lawall@xxxxxxx> wrote: > Propagate error code on failure. > > A simplified version of the semantic match that finds this problem is as > follows: (http://coccinelle.lip6.fr/) > > // <smpl> > @@ > identifier ret; expression e1,e2; > @@ > ( > if (\(ret < 0\|ret != 0\)) > { ... return ret; } > | > ret = 0 > ) > ... when != ret = e1 > when != &ret > *if(...) > { > ... when != ret = e2 > when forall > return ret; > } > // </smpl> > > Signed-off-by: Julia Lawall <Julia.Lawall@xxxxxxx> Thanks, applied for next! Kind regards Uffe > > --- > drivers/mmc/host/usdhi6rol0.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/usdhi6rol0.c b/drivers/mmc/host/usdhi6rol0.c > index 54b082b..99f894c 100644 > --- a/drivers/mmc/host/usdhi6rol0.c > +++ b/drivers/mmc/host/usdhi6rol0.c > @@ -1734,8 +1734,10 @@ static int usdhi6_probe(struct platform_device *pdev) > } > > host->clk = devm_clk_get(dev, NULL); > - if (IS_ERR(host->clk)) > + if (IS_ERR(host->clk)) { > + ret = PTR_ERR(host->clk); > goto e_free_mmc; > + } > > host->imclk = clk_get_rate(host->clk); > > -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
