On Fri, Aug 14, 2015 at 11:54:59AM +0300, Dan Carpenter wrote:
> The dma_mapping_error() function returns true or false. We should
> return -ENOMEM if it there is a dma mapping error.
Looks good to me, but should be sent to net folks now me :)
--
~Vinod
>
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
>
> diff --git a/drivers/net/ethernet/micrel/ks8842.c b/drivers/net/ethernet/micrel/ks8842.c
> index f78909a..09d2e16 100644
> --- a/drivers/net/ethernet/micrel/ks8842.c
> +++ b/drivers/net/ethernet/micrel/ks8842.c
> @@ -952,9 +952,8 @@ static int ks8842_alloc_dma_bufs(struct net_device *netdev)
>
> sg_dma_address(&tx_ctl->sg) = dma_map_single(adapter->dev,
> tx_ctl->buf, DMA_BUFFER_SIZE, DMA_TO_DEVICE);
> - err = dma_mapping_error(adapter->dev,
> - sg_dma_address(&tx_ctl->sg));
> - if (err) {
> + if (dma_mapping_error(adapter->dev, sg_dma_address(&tx_ctl->sg))) {
> + err = -ENOMEM;
> sg_dma_address(&tx_ctl->sg) = 0;
> goto err;
> }
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
