On Tue 11-08-15 00:29:55, Dan Carpenter wrote: > We know "ret" is zero here so we can remove this condition. > > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> Thanks. I've added the patch to my tree. Honza > diff --git a/fs/quota/quota.c b/fs/quota/quota.c > index 86ded73..3746367 100644 > --- a/fs/quota/quota.c > +++ b/fs/quota/quota.c > @@ -141,9 +141,9 @@ static int quota_getinfo(struct super_block *sb, int type, void __user *addr) > if (tstate->flags & QCI_ROOT_SQUASH) > uinfo.dqi_flags |= DQF_ROOT_SQUASH; > uinfo.dqi_valid = IIF_ALL; > - if (!ret && copy_to_user(addr, &uinfo, sizeof(uinfo))) > + if (copy_to_user(addr, &uinfo, sizeof(uinfo))) > return -EFAULT; > - return ret; > + return 0; > } > > static int quota_setinfo(struct super_block *sb, int type, void __user *addr) > -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
