On Tue, Aug 04, 2015 at 03:42:51PM -0700, Mathieu Olivari wrote: > Hi Dan, > You're right, that's a bug. The offset should be (x), and not (1 << x). > We could either redefine the macro to be (x), or we just use << gmac->id > directly without a macro. > The reason why we have NSS_COMMON_CLK_SRC_CTRL_RGMII & > NSS_COMMON_CLK_SRC_CTRL_SGMII macros is that the bit takes different values > depending on the port. I can post a patch today if you want. Yes, please. If you could give me a Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> tag, I would be grateful. Thanks! regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
