On Wed, 2015-07-29 at 11:17 +0100, Dan Carpenter wrote:
> The ">" should be ">=" or we end up reading beyond the end of the array.
>
> Fixes: 6e973d2c4385 ('clk: vexpress: Add separate SP810 driver')
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
>
> diff --git a/drivers/clk/versatile/clk-sp810.c b/drivers/clk/versatile/clk-sp810.c
> index 64b0129..7fbe4d4 100644
> --- a/drivers/clk/versatile/clk-sp810.c
> +++ b/drivers/clk/versatile/clk-sp810.c
> @@ -129,8 +129,8 @@ static struct clk *clk_sp810_timerclken_of_get(struct of_phandle_args *clkspec,
> {
> struct clk_sp810 *sp810 = data;
>
> - if (WARN_ON(clkspec->args_count != 1 || clkspec->args[0] >
> - ARRAY_SIZE(sp810->timerclken)))
> + if (WARN_ON(clkspec->args_count != 1 ||
> + clkspec->args[0] >= ARRAY_SIZE(sp810->timerclken)))
> return NULL;
>
> return sp810->timerclken[clkspec->args[0]].clk;
Of course.
Acked-by: Pawel Moll <pawel.moll@xxxxxxx>
Thanks!
Pawel
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
