On Thu, 16 Jul 2015, Christophe JAILLET wrote:
> There is no need to use the safe version of list_for_each here.
Why not list_for_each_entry? Maybe it's too much of a change to make at
once...
julia
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
> ---
> net/bluetooth/cmtp/capi.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/net/bluetooth/cmtp/capi.c b/net/bluetooth/cmtp/capi.c
> index b0c6c6a..4c5e3e0 100644
> --- a/net/bluetooth/cmtp/capi.c
> +++ b/net/bluetooth/cmtp/capi.c
> @@ -100,9 +100,9 @@ static void cmtp_application_del(struct cmtp_session *session, struct cmtp_appli
> static struct cmtp_application *cmtp_application_get(struct cmtp_session *session, int pattern, __u16 value)
> {
> struct cmtp_application *app;
> - struct list_head *p, *n;
> + struct list_head *p;
>
> - list_for_each_safe(p, n, &session->applications) {
> + list_for_each(p, &session->applications) {
> app = list_entry(p, struct cmtp_application, list);
> switch (pattern) {
> case CMTP_MSGNUM:
> @@ -511,13 +511,13 @@ static int cmtp_proc_show(struct seq_file *m, void *v)
> struct capi_ctr *ctrl = m->private;
> struct cmtp_session *session = ctrl->driverdata;
> struct cmtp_application *app;
> - struct list_head *p, *n;
> + struct list_head *p;
>
> seq_printf(m, "%s\n\n", cmtp_procinfo(ctrl));
> seq_printf(m, "addr %s\n", session->name);
> seq_printf(m, "ctrl %d\n", session->num);
>
> - list_for_each_safe(p, n, &session->applications) {
> + list_for_each(p, &session->applications) {
> app = list_entry(p, struct cmtp_application, list);
> seq_printf(m, "appl %d -> %d\n", app->appl, app->mapping);
> }
> --
> 2.1.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
