On Thu, Jul 9, 2015 at 8:34 AM, Jiri Kosina <jkosina@xxxxxxxx> wrote: > On Wed, 8 Jul 2015, SF Markus Elfring wrote: > >> From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> >> Date: Wed, 8 Jul 2015 22:12:25 +0200 >> >> The gpiod_put() function performs also input parameter validation >> by forwarding its single input pointer to the gpiod_free() function. >> Thus the test around the calls is not needed. >> >> This issue was detected by using the Coccinelle software. >> >> Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> > > As Dan correctly pointed out, this is not as straightforward as it might > seem on a firsr sight, because there is a WARN_ON() that might start > triggering in case of !ihid->desc. > > Adding Benjamin. I am not applying this without his Ack. > I think the gpiod case is the exception rather than the common rule (most i2c-hid device we saw until recently were using irqs, not gpios). So if I understand correctly, removing the check on ihid->desc would raise a warning for most devices. This is IMO not a good thing, so I would say NACK. Mika might have a different opinion though. Cheers, Benjamin -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
