Hi Markus, On Wed, Jul 8, 2015 at 5:09 PM, SF Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> wrote: >> There's a file in the documentation directory of the kernel >> tree describing submitting patches and email client setup. >> Read them both, > > I read this information several times. > > >> do what they say without anything extra. > > Do you see any special consequences if a bit of "extra" functionality > is already provided by the Git software for a while? If it's harmless, then no, but in this case, people are questioning why you're adding it as it adds no value to anyone and makes it look like you don't know what you're doing. >> Your attempts to "improve" on the system are unnecessary > > It seems that my approach does not need improvements for the current > command "git am". > Would a few extensions for the available documentation help to clarify > the situation? The issue is that the headers you're adding, From: and Date: are unnecessary. The From: header you add is unnecessary as your email's From: header has the exact same information. The reason it's there is because sometimes people forward patches on from other people, e.g. if I were to resend one of your patches, I'd add a From: header to the body of the email so it'd be credited to you. The Date: header you add is unnecessary as git-format-patch sets the date header in the email it produces to the author date stored in the commit. (see below) So if you're sending your patches in emails produced by git-format-patch, there's absolutely no reason to include it. > Do items like "commit mail address" and "commit timestamp" > belong together for the data structure "author" by design > in this content management system? The information stored for a commit is: = = = = = = tree 09496defc9eb793c665a7b80aa22f24c7bd5f204 parent 63c07589832bfe5ec49f2523ddb0e94a20af0f31 author Julian Calaby <julian.calaby@xxxxxxxxx> 1435196810 +1000 committer Julian Calaby <julian.calaby@xxxxxxxxx> 1436322540 +1000 = = = = = = Then the subject and commit message. The numbers after the email addresses are the timestamps. They are both almost completely irrelevant for most workflows as people are less interested in when a commit was made and more interested in what release it's in, how it was merged, etc. All of which should be determined without using the timestamp. To be honest, I've only ever used that timestamp for reporting purposes at work, and I'd be surprised if anyone was doing anything other than that with them. In short, nobody cares, and nobody's going to be upset if the actual time you authored a patch is different to the time recorded upstream. >> and annoying people. > > I understand that various update suggestions can be surprising. > It is also usual that corresponding acceptance might take > a bit longer than what some contributors would prefer. How would you feel if someone came in to your place of work and told you to change how you do the job you've been doing for years without a good reason? Thanks, -- Julian Calaby Email: julian.calaby@xxxxxxxxx Profile: http://www.google.com/profiles/julian.calaby/ -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
