On 06/29/2015 04:02 PM, SF Markus Elfring wrote:
tcegrp will be NULL and kfree() can handle this just fine
The affected function did not show this API knowledge, did it?
but you fixed this in 1/2 :)
(is not it the whole point of this patchset
- remove the check and just call kfree() even if the pointer is NULL?).
Partly, yes.
And if you wanted another label,
I suggest this to improve corresponding exception handling.
than the existing one should have been renamed to "free_exit" or "free_unlock_exit"
and new one would be "unlock_exit".
I chose a smaller change at this place.
I'd just drop this patch.
I am not familiar enough with other called functions there at the moment.
Are the remaining goto statements also update candidates?
--
Alexey
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
