On Wed, 2015-06-24 at 17:54 +0200, SF Markus Elfring wrote: > From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> > Date: Wed, 24 Jun 2015 17:50:32 +0200 > > The fc_fcp_ddp_done() function tests whether its argument is NULL and then > returns immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> > --- > drivers/scsi/libfc/fc_exch.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/scsi/libfc/fc_exch.c b/drivers/scsi/libfc/fc_exch.c > index 1b3a094..aad6f48 100644 > --- a/drivers/scsi/libfc/fc_exch.c > +++ b/drivers/scsi/libfc/fc_exch.c > @@ -2120,8 +2120,7 @@ static struct fc_seq *fc_exch_seq_send(struct fc_lport *lport, > spin_unlock_bh(&ep->ex_lock); > return sp; > err: > - if (fsp) > - fc_fcp_ddp_done(fsp); > + fc_fcp_ddp_done(fsp); > rc = fc_exch_done_locked(ep); > spin_unlock_bh(&ep->ex_lock); > if (!rc) Looks good. Acked-by: Vasu Dev <vasu.dev@xxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
