Hi On Wed, Jun 24, 2015 at 2:40 PM, SF Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> wrote: > From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> > Date: Wed, 24 Jun 2015 14:30:17 +0200 > > The kdbus_domain_unref() function tests whether its argument is NULL > and then returns immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> > --- > ipc/kdbus/fs.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/ipc/kdbus/fs.c b/ipc/kdbus/fs.c > index d01f33b..205a3ad 100644 > --- a/ipc/kdbus/fs.c > +++ b/ipc/kdbus/fs.c > @@ -325,9 +325,7 @@ static void fs_super_kill(struct super_block *sb) > } > > kill_anon_super(sb); > - > - if (domain) > - kdbus_domain_unref(domain); > + kdbus_domain_unref(domain); Yeah, your patch is correct. The condition was kinda nice as it shows the connection to the tear-down before the call to kill_anon_super(). But the function is simple enough for a reader to figure out themselves. Reviewed-by: David Herrmann <dh.herrmann@xxxxxxxxx> Thanks David > } > > static int fs_super_set(struct super_block *sb, void *data) > -- > 2.4.4 > -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
