On Sat, 20 Jun 2015, Joachim Eastwood wrote: > On 20 June 2015 at 21:07, Julia Lawall <Julia.Lawall@xxxxxxx> wrote: > > Remove initialization of a variable that is immediately reassigned. > > > > The semantic patch that makes this change is as follows: > > (http://coccinelle.lip6.fr/) > > > > // <smpl> > > @@ > > type T; > > identifier x; > > constant C; > > expression e; > > @@ > > > > T x > > - = C > > ; > > x = e; > > // </smpl> > > > > Signed-off-by: Julia Lawall <Julia.Lawall@xxxxxxx> > > > > --- > > drivers/staging/lustre/lustre/osc/osc_page.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff -u -p a/drivers/staging/lustre/lustre/osc/osc_page.c b/drivers/staging/lustre/lustre/osc/osc_page.c > > --- a/drivers/staging/lustre/lustre/osc/osc_page.c > > +++ b/drivers/staging/lustre/lustre/osc/osc_page.c > > @@ -471,7 +471,7 @@ static int osc_page_flush(const struct l > > struct cl_io *io) > > { > > struct osc_page *opg = cl2osc_page(slice); > > - int rc = 0; > > + int rc; > > > > rc = osc_flush_async_page(env, io, opg); > > return rc; > > > > The whole rc variable is kinda useless. > > Why not make it just: > return osc_flush_async_page(env, io, opg); Sure. I'll fix that. julia -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
