On Thu, 11 Jun 2015 09:41:10 +0800 Firo Yang <firogm@xxxxxxxxx> wrote: > Warning like this: > > drivers/md/md.c: In function ‘update_array_info’: > drivers/md/md.c:6394:26: warning: logical not is only applied > to the left hand side of comparison [-Wlogical-not-parentheses] > !mddev->persistent != info->not_persistent|| > > Fix it as Neil Brown said: > mddev->persistent != !info->not_persistent || > > Signed-off-by: Firo Yang <firogm@xxxxxxxxx> > --- > drivers/md/md.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/md/md.c b/drivers/md/md.c > index dd85be9..a3528b9 100644 > --- a/drivers/md/md.c > +++ b/drivers/md/md.c > @@ -6391,7 +6391,7 @@ static int update_array_info(struct mddev *mddev, mdu_array_info_t *info) > mddev->ctime != info->ctime || > mddev->level != info->level || > /* mddev->layout != info->layout || */ > - !mddev->persistent != info->not_persistent|| > + mddev->persistent != !info->not_persistent || > mddev->chunk_sectors != info->chunk_size >> 9 || > /* ignore bottom 8 bits of state, and allow SB_BITMAP_PRESENT to change */ > ((state^info->state) & 0xfffffe00) applied, thanks. NeilBrown -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
