Re: [patch] [patch 2/2 v2] w1: use correct lock on error in w1_seq_show()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi

04.06.2015, 12:04, "Dan Carpenter" <dan.carpenter@xxxxxxxxxx>:
> I noticed there was a problem here because Smatch complained:
>
>         drivers/w1/slaves/w1_therm.c:416 w1_seq_show() warn:
>         inconsistent returns 'mutex:&sl->master->mutex'.
>           Locked on: line 416
>           Unlocked on: line 413
>
> The problem is that we lock ->mutex but we unlock ->bus_mutex on error.
> David Fries says that ->bus_mutex is correct and ->mutex is incorrect.
>
> Fixes: d9411e57dc7f ('w1: Add support for DS28EA00 sequence to w1-therm')
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

Looks good to me, Greg please pull this serie into your tree, if you hadn't yet.
Am I right that this is a stable tree material too?

Acked-by: Evgeniy Polyakov <zbr@xxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux