> @@ -182,21 +182,12 @@ static int pxa_ssp_probe(struct platform_device *pdev)
> return -ENODEV;
> }
Actually, the code up here is a check that res is not null. You can drop
that as well. devm_ioremap_resource checks the same thing.
julia
>
> - res = devm_request_mem_region(dev, res->start, resource_size(res),
> - pdev->name);
> - if (res == NULL) {
> - dev_err(dev, "failed to request memory resource\n");
> - return -EBUSY;
> - }
> + ssp->mmio_base = devm_ioremap_resource(dev, res);
> + if (IS_ERR(ssp->mmio_base))
> + return PTR_ERR(ssp->mmio_base);
>
> ssp->phys_base = res->start;
>
> - ssp->mmio_base = devm_ioremap(dev, res->start, resource_size(res));
> - if (ssp->mmio_base == NULL) {
> - dev_err(dev, "failed to ioremap() registers\n");
> - return -ENODEV;
> - }
> -
> ssp->irq = platform_get_irq(pdev, 0);
> if (ssp->irq < 0) {
> dev_err(dev, "no IRQ resource defined\n");
> --
> 2.4.2
>
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
